Skip to content

Conversation

@MWP
Copy link
Contributor

@MWP MWP commented Jun 10, 2025

Updates to the ILI9881c panel driver and crystalfontz-cfa050_pi_m dt overlay to add support for Raspberry Pi Compute Module 5.

Signed-off-by: Mark Williams [email protected]

@pelwell
Copy link
Contributor

pelwell commented Jun 10, 2025

The changes look OK to me. Can you squash them down to two commits - code in one, dts and README in the other - then force push it to your branch?

@6by9
Copy link
Contributor

6by9 commented Jun 10, 2025

I agreed with pelwell - all looks fine except for wanting to be in only 2 commits.

Do note the detail in https://pip.raspberrypi.com/categories/685-app-notes-guides-whitepapers/documents/RP-003472-WP/Using-a-DSI-display.pdf which describes the DSI clock structure for vc4 and the use of integer dividers.
I haven't computed all the numbers, but gut feel is that you won't get the exact 78000kHz pixel clock you're asking for. On two lanes vc4 the nearest was 83333kHz, and I suspect the same is true on 4 lanes. For consistency I've tended to do the fixup manually and use that in the mode definition so that the same output is generated on both platforms.

MWP added 2 commits June 11, 2025 09:26
Update of ILI9881C CFAF7201280A0-050TX panel timing to work with the CM5.

Signed-off-by: Mark Williams <[email protected]>
Update DT Overlay to support CFA050-PI-M with CM5. Also udpated README to suit.

Signed-off-by: Mark Williams <[email protected]>
@MWP
Copy link
Contributor Author

MWP commented Jun 11, 2025

My apologies for the PR mess. I don't do this very often.

@pelwell
Copy link
Contributor

pelwell commented Jun 11, 2025

It wasn't a mess, and it's not a problem. Adding patches to address specific review points can make things easier to follow, but we like to keep things tidy when merging, particularly avoiding intermediate "bad" states that would catch somebody out if bisecting to find when a bug was introduced. GitHub makes it easy to squash at merge time, but that's only useful when a whole PR results in one commit.

@pelwell
Copy link
Contributor

pelwell commented Jun 11, 2025

Merged offline, in order to fix up the commit messages and whitespace (which was forgotten, then patched up in a 3rd commit...)

@pelwell pelwell closed this Jun 11, 2025
popcornmix added a commit to raspberrypi/firmware that referenced this pull request Jun 12, 2025
kernel: Updates to support CM5 on the Crystalfontz CFA050-PI-M
See: raspberrypi/linux#6889

kernel: Side-port dwc_otg fixes to dwc2
See: raspberrypi/linux#6892

kernel: Also build kernel8_rt
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Jun 12, 2025
kernel: Updates to support CM5 on the Crystalfontz CFA050-PI-M
See: raspberrypi/linux#6889

kernel: Side-port dwc_otg fixes to dwc2
See: raspberrypi/linux#6892

kernel: Also build kernel8_rt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants